Skip to content

Gutenberg related changes to land after 16.3 App cut #13504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cameronvoell merged 22 commits into from
Dec 1, 2020
Merged

Gutenberg related changes to land after 16.3 App cut #13504

cameronvoell merged 22 commits into from
Dec 1, 2020

Conversation

@cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Dec 1, 2020 •
edited
Loading

This PR is for merging Gutenberg related changes to WPAndroid develop that were ongoing during the Gutenberg Editor 1.42.0 code freeze

PLEASE DO NOT MERGE until after 16.3 Release is cut on WPAndroid develop. Thank you!

To Test:
See steps from: #13413

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

jd-alexander and others added 20 commits November 17, 2020 18:05
@jd-alexander
Updated ref for wp media picker.
e6be88e
@jd-alexander
Added support to the MediaBrowserType for a single file picker
24665ad
@jd-alexander
the media picker setup now has support for selecting files.
e7c7166
@jd-alexander
implemented listener behavior to trigger picker action from the block.
fc8fcfe
@jd-alexander
Updated ref
187b642
@jd-alexander
Utilize the consolidated media picker for file picking.
850f6cf
@jd-alexander
configured multiselect for file picker behavior.
6c75b06
@jd-alexander
MediaBrowserActivity File Picker action now does multiselect by default.
9723ab9
@jd-alexander
removed the SINGLE_FILE_PICKER from here since its not an IMAGE_PICKER
979868e
@jd-alexander
The SINGLE_FILE_PICKER is associated with isSingleMediaPicker
d54ef3f 
This was done so there's a a single file picker type. Now when the Media Browser is launched with this BrowserType a file can be selected.
@jd-alexander
fixed lint errors
2690759
@jd-alexander
Created isSingleFilePicker so a single file can be selected.
eeabd44
@jd-alexander
removed unneeded line.
5f1bfa2
@jd-alexander
Updated gb ref.
08d816c
@jd-alexander
Merge branch 'develop' into file-block-III-wp-media-picker
5dcf658
@jd-alexander
Updated gb ref.
9518cdf
@etoledom
Update gutenberg ref
49db75a
@jd-alexander
Update gutenberg ref.
410d746
@jd-alexander
Merge pull request #13413 from wordpress-mobile/file-block-III-wp-med…
86292a7 
…ia-picker

[Gutenberg] File Block : Consolidated Media Picker + WP Media Source integration
@jd-alexander
Merge branch 'develop' into gutenberg/after_1.42.0
4ffffa4
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 1, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@cameronvoell cameronvoell added this to the 16.4 milestone Dec 1, 2020
@cameronvoell cameronvoell requested a review from ceyhun December 1, 2020 02:45
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 1, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

ceyhun
ceyhun approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be better to point the gb-mobile hash to the same as WPiOS one

@cameronvoell
Copy link
Contributor Author

cameronvoell commented Dec 1, 2020

It could be better to point the gb-mobile hash to the same as WPiOS one

Updated! 7f6ce08

@cameronvoell cameronvoell merged commit a758cc0 into develop Dec 1, 2020
@cameronvoell cameronvoell deleted the gutenberg/after_1.42.0 branch December 1, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ceyhun ceyhun ceyhun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

16.4

Development

Successfully merging this pull request may close these issues.

5 participants

@cameronvoell @ceyhun @jd-alexander @etoledom